Remove unsound impl Bytes for bool and char#101
Merged
stouset merged 1 commit intostouset:masterfrom Aug 14, 2025
Merged
Conversation
stouset
approved these changes
Aug 13, 2025
Owner
|
I apologize. For some reason I haven't been getting email notifications about this repository, so issues/PRs have gone unnoticed. |
stouset
force-pushed
the
patch-1
branch
2 times, most recently
from
872b742 to
1bc5609
Compare
`bool` and `char` are not able to have any arbitrary bit-pattern, so they should not implement `Bytes`. fixes stouset#100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boolandcharare not able to have any arbitrary bit-pattern, so they should not implementBytes.fixes #100